Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add theme ananthb/jughead #473

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add theme ananthb/jughead #473

wants to merge 1 commit into from

Conversation

ananthb
Copy link

@ananthb ananthb commented Jun 21, 2024

ananthb/jughead is a lightweight blog theme for Hugo.

After you have read the instructions for adding a theme, please make sure:

Copy link

netlify bot commented Jun 21, 2024

Deploy Preview for hugothemes ready!

Name Link
🔨 Latest commit d63745d
🔍 Latest deploy log https://app.netlify.com/sites/hugothemes/deploys/667742d5850bb00008a97b3d
😎 Deploy Preview https://deploy-preview-473--hugothemes.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ananthb/jughead is a lightweight blog theme for Hugo.
@hugo-sid
Copy link
Member

hugo-sid commented Jul 26, 2024

Thanks for adding your theme.

From the README:

  1. Forks must be notably different
    A theme based on an existing Hugo theme (aka a fork) must be notably different for it to be considered a separate theme altogether. In such cases, you should list few arguments in README.md file mentioning why your theme should be included.

The definition of notably different can be subjective, but in most cases, it should be clear. Changing a few colors or making a few style changes, for example, does not result in a notably different theme. It would be better if you submit a pull request to the original theme to include your proposed changes.

Can you list a few arguments in README.md which shows how your theme is different than the original theme?

@ananthb
Copy link
Author

ananthb commented Jul 26, 2024

Sure thing.

On the surface it's similar, but visually I've fixed issues with incorrect spacing, colour contrast issues, and colour palette accessibility issues.

A lot has changed internally in how the theme loads different features. I've re-worked how comments work and I've added support for diagrams, charts, etc.

I've also added better support for Hugo asset pipelines which makes sites load faster and work better. I've also started preliminary work for internationalisation support.

I plan on going a different direction visually now that the internals have largely been figured out.

@ananthb
Copy link
Author

ananthb commented Jul 26, 2024

I'll add this note to the readme shortly.

@ananthb
Copy link
Author

ananthb commented Jul 26, 2024

@hugo-sid I've added a section to my theme's README talking about the reason behind the fork, what's different, and about future plans as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants